fix: menu style broken in dropdown #19150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
changed the title
|
Deploy preview for ant-design ready! Built with commit d077b51 |
|
ci 莫名其妙的挂了。 |
Codecov Report
@@ Coverage Diff @@
## master #19150 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 282 282
Lines 7622 7622
Branches 2143 2143
=======================================
Hits 7452 7452
Misses 170 170Continue to review full report at Codecov.
|
orzyyyy
reviewed
Oct 12, 2019
|
|
||
| ## zh-CN | ||
|
|
||
| 此演示用于调试 Menu 完整样式。 |
There was a problem hiding this comment.
这里贴个 demo 用途吧，不然其他人到时候都不知道该看什么。比如：
此 demo 需要注意查看 Dropdown 下部分 Menu 的样式是否正常
#19150
|
/rebase |
github-actions
bot
force-pushed
the
fix-menu-style
branch
from
2cfcf66
to
bf8dffc
Compare
|
@afc163 更新下 snapshot 就可以了 |
|
不行，dist 的 snapshot 和其他环境不一样。 |
shaodahong
reviewed
Oct 12, 2019
| ); | ||
|
|
||
| ReactDOM.render( | ||
| <Dropdown overlay={menu} visible> |
There was a problem hiding this comment.
加上 visible 会导致 snapshot 在 dist 模式下和其他模式不一致，非常奇怪。所有 trigger 组件都有这个问题。
cc @zombieJ
这里和本 PR 无关，我先把例子里的 visible 删了。
afc163
force-pushed
the
fix-menu-style
branch
3 times, most recently
from
7f1b94f
to
6c3a677
Compare
afc163
force-pushed
the
fix-menu-style
branch
from
6c3a677
to
9e960ae
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
close #19145
💡 Background and solution
to
📝 Changelog
☑️ Self Check before Merge
View rendered components/dropdown/demo/menu-full.md