Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: keep className given to expandIcon in Collapse component #19160

Merged
merged 1 commit into from Oct 11, 2019
Merged

Fix: keep className given to expandIcon in Collapse component #19160

merged 1 commit into from Oct 11, 2019

Conversation

gpetrioli
Copy link
Contributor

@gpetrioli gpetrioli commented Oct 10, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixes #19158

💡 Background and solution

use classNames method to add the `${prefixCls}-arrow` to the existing classNames instead of overwriting them.

📝 Changelog

Class name given to the expandIcon of the Collapse component will be maintained so that might pose a change if users expected it to be lost.

Language Changelog
🇺🇸 English Keep className given to expandIcon in Collapse component
🇨🇳 Chinese 保留 Collapse 组件中 expandIcon 自定义 className

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for ant-design ready!

Built with commit c8716e2

https://deploy-preview-19160--ant-design.netlify.com

@shaodahong
Copy link
Member

CI broken

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #19160 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19160   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         282      282           
  Lines        7548     7548           
  Branches     2110     2110           
=======================================
  Hits         7346     7346           
  Misses        201      201           
  Partials        1        1
Impacted Files Coverage Δ
components/collapse/Collapse.tsx 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b1f90...c8716e2. Read the comment docs.

@gpetrioli gpetrioli changed the title Keep className given to expandIcon in Collapse component Fix: keep className given to expandIcon in Collapse component Oct 10, 2019
@auto-add-label auto-add-label bot added the Fix label Oct 10, 2019
@shaodahong shaodahong merged commit 3ac716d into ant-design:master Oct 11, 2019
@pr-triage pr-triage bot added the PR: merged label Oct 11, 2019
@shaodahong
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse expandIcon losing given className
2 participants