Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace autosize with autoSize #19177

Merged
merged 1 commit into from Oct 11, 2019
Merged

Conversation

jinliming2
Copy link
Contributor

@jinliming2 jinliming2 commented Oct 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

  1. 💥 Ant Design 4.0 is in progress! #16911 (comment)

💡 Background and solution

  1. Input.TextAreaautosize 属性更改为 autoSize

📝 Changelog

Language Changelog
🇺🇸 English 🗑 Deprecated Input.TextArea autosize prop and use autoSize instead. #19177
🇨🇳 Chinese 🗑 废弃 Input.TextArea 的 autosize 属性,请使用 autoSize 代替。 #19177

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/autosize-textarea.md
View rendered components/input/demo/textarea-resize.md
View rendered components/input/index.en-US.md
View rendered components/input/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Oct 11, 2019

Deploy preview for ant-design ready!

Built with commit 41fa8b3

https://deploy-preview-19177--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Oct 11, 2019

image

changelog 这样改一下吧

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #19177 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19177      +/-   ##
==========================================
+ Coverage   97.32%   97.32%   +<.01%     
==========================================
  Files         282      282              
  Lines        7548     7550       +2     
  Branches     2067     2069       +2     
==========================================
+ Hits         7346     7348       +2     
  Misses        201      201              
  Partials        1        1
Impacted Files Coverage Δ
components/typography/Editable.tsx 100% <ø> (ø) ⬆️
components/input/TextArea.tsx 96.49% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43b808...41fa8b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants