fix: fix cascader placeholder internationalization #19227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit 792a701 |
kagawagao
changed the title
kagawagao
changed the title
|
/rebase |
1 similar comment
|
/rebase |
afc163
reviewed
Oct 15, 2019
| @@ -429,7 +429,7 @@ class Cascader extends React.Component<CascaderProps, CascaderState> { | |||
| prefixCls: customizePrefixCls, | |||
| inputPrefixCls: customizeInputPrefixCls, | |||
| children, | |||
| placeholder = locale.placeholder, | |||
| placeholder = locale.placeholder || 'Please select', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
latest website
https://codesandbox.io/s/infallible-mountain-pt2tj
馃挕 Background and solution
Cascader's propplaceholderworks not correctly withLocaleProvider/ConfigProviderant-design/components/cascader/index.tsx
Line 219 in 8ffaeb8
ant-design/components/cascader/index.tsx
Line 433 in 8ffaeb8
because
placeholderexists indefaultProps,locale.placeholderwill not workremove
placeholderfromdefaultPropsworks well馃摑 Changelog
Cascaderplaceholder internationalizationCascader鍗犱綅绗﹀浗闄呭寲閿欒鈽戯笍 Self Check before Merge