fix: Notification hooks #24337
Merged
fix: Notification hooks #24337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
Codecov Report
@@ Coverage Diff @@
## master #24337 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 363 363
Lines 7271 7272 +1
Branches 2022 2022
=======================================
+ Hits 7186 7187 +1
Misses 85 85
Continue to review full report at Codecov.
|
|
|
|
这个 changelog 写的不好，没有从用户角度出发。 |
|
嗯，我写的时候也很纠结。不知道怎么写更好些。 |
|
试着写了一下：#24410 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #24334
💡 Background and solution
📝 Changelog
useNotificationapi instance to be same instance for each render.useNotificationapi 实例在每次渲染时都返回相同实例。☑️ Self Check before Merge