Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix breadcrumb separator #25984

Merged
merged 3 commits into from Aug 3, 2020
Merged

fix: fix breadcrumb separator #25984

merged 3 commits into from Aug 3, 2020

Conversation

flyerH
Copy link
Contributor

@flyerH flyerH commented Aug 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25975

💡 Background and solution

Add a default separator for BreadcrumbItem.

📝 Changelog

Language Changelog
🇺🇸 English Fix Breadcrumb.Item lost separator after wrapping in component.
🇨🇳 Chinese 修复 Breadcrumb.Item 封装后丢失分隔符的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@flyerH flyerH changed the title fix breadcrumb separator fix: fix breadcrumb separator Aug 3, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 3, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 3, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11bb2ff:

Sandbox Source
antd reproduction template Configuration
flamboyant-faraday-tp9fg Issue #25975

Copy link
Contributor

@MrHeer MrHeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR has only one commit and it's not semantic.

@flyerH
Copy link
Contributor Author

flyerH commented Aug 3, 2020

Your PR has only one commit and it's not semantic.

updated 😁

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #25984 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25984   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7313     7314    +1     
  Branches     2041     1994   -47     
=======================================
+ Hits         7282     7283    +1     
  Misses         31       31           
Impacted Files Coverage Δ
components/breadcrumb/BreadcrumbItem.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7f7b4...11bb2ff. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 3, 2020

Could you add a test case?

image

@afc163 afc163 merged commit c4418d0 into ant-design:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb.Item的重构出现了不兼容
4 participants