Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复紧凑模式下表单项 margin 计算错误 #26069

Merged
merged 1 commit into from Aug 7, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Aug 6, 2020

close #25989

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25989

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 修复紧凑模式下表单项 margin 计算错误
🇨🇳 Chinese fix form-item margin is uncorrect in compact mode

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 6, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 6, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit feb6083:

Sandbox Source
antd reproduction template Configuration

@07akioni
Copy link
Contributor

07akioni commented Aug 7, 2020

CI failed, maybe you need to rebase

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #26069 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26069   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         373      373           
  Lines        7315     7315           
  Branches     1994     1994           
=======================================
  Hits         7283     7283           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d23ac...feb6083. Read the comment docs.

@afc163 afc163 merged commit 73ce401 into ant-design:master Aug 7, 2020
@afc163
Copy link
Member

afc163 commented Aug 7, 2020

下次用英文写 commit message 和 PR 标题,我合并太快了。。

@AshoneA
Copy link
Contributor Author

AshoneA commented Aug 7, 2020

下次用英文写 commit message 和 PR 标题,我合并太快了。。

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form jumps when got validation error in compact mode
4 participants