Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Steps progress circle size & rtl style when use progress #26075

Merged
merged 3 commits into from Aug 9, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Aug 7, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image
Progress circle should follow the design.
image
RTL style has glitch

📝 Changelog

Language Changelog
🇺🇸 English Fix Steps rtl style when use progress.
🇨🇳 Chinese 修复 Steps 使用 progress 时的 rtl 样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 7, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 7, 2020

@xrkffgg
Copy link
Member

xrkffgg commented Aug 7, 2020

之前发现这个的 RTL 有点小问题,老兄,你顺便瞅一眼

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e672d93:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2020

Size Change: +108 B (0%)

Total Size: 799 kB

Filename Size Change
./dist/antd.compact.min.css 64.8 kB +41 B (0%)
./dist/antd.dark.min.css 66.1 kB +30 B (0%)
./dist/antd.min.css 64.8 kB +37 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 318 kB 0 B
./dist/antd.min.js 286 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #26075 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26075   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         373      373           
  Lines        7315     7315           
  Branches     2044     1994   -50     
=======================================
  Hits         7283     7283           
  Misses         32       32           
Impacted Files Coverage Δ
components/steps/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ade6da...e672d93. Read the comment docs.

@07akioni 07akioni changed the title fix: Steps progress circle size fix: Steps progress circle size & rtl style when use progress Aug 7, 2020
@07akioni
Copy link
Contributor Author

07akioni commented Aug 7, 2020

之前发现这个的 RTL 有点小问题,老兄,你顺便瞅一眼

修复了

@xrkffgg xrkffgg merged commit f964abc into master Aug 9, 2020
@xrkffgg xrkffgg deleted the fix-steps-style branch August 9, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants