fix: Avatar.Group key lost #26098
Merged
fix: Avatar.Group key lost #26098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 32a57b4:
|
|
Size Change: +56 B (0%) Total Size: 799 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## master #26098 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 373 373
Lines 7315 7316 +1
Branches 2044 2042 -2
=======================================
+ Hits 7283 7284 +1
Misses 32 32
Continue to review full report at Codecov.
|
afc163
reviewed
Aug 9, 2020
| key: `avatar-key-${index}`, | ||
| }); | ||
| }); | ||
|
|
||
| const numOfChildren = childrenWithProps.length; | ||
| if (maxCount && maxCount < numOfChildren) { |
There was a problem hiding this comment.
没进 if 的时候直接用 children 就可以了吧？没必要 toArray 一下。
xrkffgg
commented
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #26087
💡 Background and solution
📝 Changelog
keyof Avatar.Group.key缺失的问题。☑️ Self Check before Merge