Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix DirectoryTree miss ref.scrollTo function #26129

Merged
merged 2 commits into from Aug 11, 2020
Merged

fix: Fix DirectoryTree miss ref.scrollTo function #26129

merged 2 commits into from Aug 11, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 11, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DirectoryTree can not use scrollTo with ref.
🇨🇳 Chinese 修复 DirectoryTree 不能通过 ref 调用 scrollTo 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 11, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 11, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0cd8ed2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #26129 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26129   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         373      373           
  Lines        7316     7319    +3     
  Branches     2035     1994   -41     
=======================================
+ Hits         7284     7287    +3     
  Misses         32       32           
Impacted Files Coverage Δ
components/tree/DirectoryTree.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b9f6e...0cd8ed2. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +62 B (0%)

Total Size: 799 kB

Filename Size Change
./dist/antd-with-locales.min.js 317 kB +32 B (0%)
./dist/antd.min.js 286 kB +30 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 64.8 kB 0 B
./dist/antd.dark.min.css 66.1 kB 0 B
./dist/antd.min.css 64.8 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants