fix: #26126 use mergedData instead of pageData to decide whether to render bottom pagination or not #26133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… render bottom pagination
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ac4543:
|
Codecov Report
@@ Coverage Diff @@
## master #26133 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 373 373
Lines 7316 7316
Branches 2035 2044 +9
=======================================
Hits 7284 7284
Misses 32 32
Continue to review full report at Codecov.
|
|
close #25836 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #26126
💡 Background and solution
Currently, when using backend pagination (meaning manually managing property pagination.total), if the last record on the last page is deleted, and pagination becomes invisible(which should not happen), since length of records is not 0.
Use mergeData.length to decide whether to render bottom pagination should fix the problem.
📝 Changelog
☑️ Self Check before Merge