Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add export handleStyle/trackStyle #26160

Merged
merged 1 commit into from Aug 12, 2020
Merged

fix: add export handleStyle/trackStyle #26160

merged 1 commit into from Aug 12, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 12, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26154

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Slider handleStyle and trackStyle TypeScript definitions.
🇨🇳 Chinese 修复 Slider handleStyletrackStyle TS 定义。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 12, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 12, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 263a5e0:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #26160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26160   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         373      373           
  Lines        7315     7315           
  Branches     2040     2040           
=======================================
  Hits         7282     7282           
  Misses         33       33           
Impacted Files Coverage Δ
components/slider/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af16da1...263a5e0. Read the comment docs.

@afc163 afc163 merged commit 2e463e7 into master Aug 12, 2020
@afc163 afc163 deleted the fix-slider branch August 12, 2020 07:03
@pr-triage pr-triage bot added the PR: merged label Aug 12, 2020
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 799 kB

ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 317 kB 0 B
./dist/antd.compact.min.css 64.9 kB 0 B
./dist/antd.dark.min.css 66.1 kB 0 B
./dist/antd.min.css 64.9 kB 0 B
./dist/antd.min.js 286 kB 0 B

compressed-size-action

@afc163 afc163 mentioned this pull request Aug 12, 2020
19 tasks
@emjeard
Copy link

emjeard commented Sep 10, 2020

trackStyle & handleStyle not work with range options. can you fix this issue?
i try this code:
<Slider defaultValue={30} disabled={disabled} trackStyle={{ backgroundColor: "red" }}
handleStyle={{ borderColor: "red" }}/>
<Slider range defaultValue={[20, 50]} disabled={disabled} trackStyle={{ backgroundColor: "red" }}
handleStyle={{ borderColor: "red" }}/>
Disabled:

on this https://codesandbox.io/s/frxfx?file=/index.js:386-773

@vivek-wednesday
Copy link

vivek-wednesday commented Sep 27, 2021

@emjeard or anyone who stumbles on this issue, should try passing the track/handleStyles inside an array.
Example: handleStyle={[{ borderColor: "red" }]}/>

@jagaa999
Copy link

@emjeard or anyone who stumbles on this issue, should try passing the track/handleStyles inside an array. Example: handleStyle={[{ borderColor: "red" }]}/>

This help me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide type props: trackStyle and handleStyle for Slider component
6 participants