Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image 相册模式 Image.PreviewGroup，如果里面的子项 src 有错误的话，相册模式会自动忽略该子项。如： <Image src="error.url" /> #38112

Closed
tigepro opened this issue Oct 19, 2022 · 2 comments · Fixed by react-component/image#130
Closed

Image 相册模式 Image.PreviewGroup，如果里面的子项 src 有错误的话，相册模式会自动忽略该子项。如： <Image src="error.url" /> #38112

tigepro opened this issue Oct 19, 2022 · 2 comments · Fixed by react-component/image#130
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@tigepro
Copy link

tigepro commented Oct 19, 2022

Reproduction link

https://codepen.io/fengyu_xu/pen/oNYJZjP

Steps to reproduce

https://codepen.io/fengyu_xu/pen/oNYJZjP

What is expected?

如果子项有错误 直接展示错误

What is actually happening?

直接忽略，好像不存在该子项一样

Environment Info
antd 4.23.1
React 18.2.0
System Mac
Browser Chrome
@tigepro tigepro changed the title Image 相册模式 Image.PreviewGroup，里面的如果子项的 src 有错误的话，相册模式会自动忽略该子项。如： <Image src="error.url" /> Image 相册模式 Image.PreviewGroup，如果里面的子项 src 有错误的话，相册模式会自动忽略该子项。如： <Image src="error.url" /> Oct 19, 2022
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Oct 19, 2022
@github-actions
Copy link
Contributor

Hello @tigepro. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @tigepro，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

giphy

@huangkairan
Copy link
Contributor

WIP

@huangkairan huangkairan mentioned this issue Oct 19, 2022
Merged
This was referenced Nov 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Image): should show error img in previewGroup huangkairan/image
3 participants
@afc163 @tigepro @huangkairan