Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Injections: use correct range when processing #190

Open
ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Open

Language Injections: use correct range when processing #190

ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 3, 2024

Currently, there's a code in the language inhection processor that always reconstructs the text range from the edited element.

The reason for that behavior is unclear. Ideally, we should use the passed text range and not rely on the whole content. Perhaps we can act in a more optimal way.

See the code near this line:

// val newString = oldText.substring(0, range.startOffset) + escapeString(element, newContent) + oldText.substring(range.endOffset)//todo fix range to use it from parameter

Also, look for the number of this issue in the project code base.

@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed labels Mar 3, 2024
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant