Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Injections: merge the escaping methods #191

Open
ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Open

Language Injections: merge the escaping methods #191

ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 3, 2024

Currently, we have two main string escape mechanisms used when editing the injected language fragments: com.intellij.plugin.powershell.lang.util.PowerShellStringUtil#escapeStringCharacters and com.intellij.plugin.powershell.ide.injection.PowerShellStringManipulator#escapeQuotes. Near the latter, there's a comment suggesting to merge them both in one function.

We should consider that.

See the code near this line:

//todo implement in PowerShellStringUtil.escapeStringCharacters()

Also, look for the number of this issue in the project code base.

@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed labels Mar 3, 2024
@ForNeVeR ForNeVeR changed the title Language Injections: implement more escaping Language Injections: merge the escaping methods Mar 3, 2024
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant