Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate what happens in the rename processor #192

Open
ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Open

Investigate what happens in the rename processor #192

ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 3, 2024

See the code near this line:

if (element is PowerShellComponent && nameHasSubExpression(element)) {//todo it's workaround to resort to findUsage handler because default index does not contain needed tokens

Also, look for the number of this issue in the project code base.

It explains an issue that caused us to rely on the find usages handler instead of the normal code flow in that place. The message from the commit introducing that line (7d1415e) also tries to explain a bit:

  • if identifier has sub-expression search for references using Find Usages Handler

I don't fully understand what's happening there currently, though: what is a PowerShellComponent? What does "identifier has sub-expression" mean? Is it about "identifiers" such as $script:MyVariable? Why is something not handled by the default flow there?

We should figure it out and either fix or provide a better explanation.

@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed labels Mar 3, 2024
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant