Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way we determine/parse a module version #196

Open
ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Open

Improve the way we determine/parse a module version #196

ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 3, 2024

See the code near this line:

This is used by the plugin to determine the version of the PowerShellEditorServices module.

Currently the code is very simple, maybe even too simple: if the module authors decide to write its version in a minimally more convoluted way, it will certainly break.

Ideally, we should maybe navigate the PSI or something. Or maybe totally migrate to determining this version asynchronously by starting PowerShell.

Why do we even need that? So many questions…

@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 3, 2024
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant