Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShellReferencePsiElementImpl::getNameElement implementation #199

Open
ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Open

PowerShellReferencePsiElementImpl::getNameElement implementation #199

ForNeVeR opened this issue Mar 3, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 3, 2024

See the code near this line:

override fun getNameElement(): PsiElement? = findChildByClass(PowerShellIdentifier::class.java) //todo

Apparently, the TODO comment appeared because it's too simple or dubious. We should investigate and either improve the implementation or remove the comment if we currently believe this is enough.

Maybe not all references contain a child PowerShellIdentifier?

@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed labels Mar 3, 2024
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
ForNeVeR added a commit that referenced this issue Mar 3, 2024
…, #202) Connect TODOs with the issues, TODO cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant