Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider improve bindings #24

Open
creekorful opened this issue Jan 21, 2021 · 2 comments
Open

Consider improve bindings #24

creekorful opened this issue Jan 21, 2021 · 2 comments

Comments

@creekorful
Copy link
Collaborator

creekorful commented Jan 21, 2021

Hello,

Just a little suggestion (it may sounds a little opinionated)

I think using two keystrokes to trigger an action may be counter-productive sometimes, I like the Tab & Enter key to focus between panes / select a sites.

What do you think adding Enter key as trigger for LoadContent (while keeping Ctrl+O to not disturb existing users) and Escape as a way to exit content panel (while keeping Ctrl+Q).

Otherwise another idea could be to allow users to customize binding using a config file inside .terminews folder.

I'll be willing to do the PR if you mind.

@antavelos
Copy link
Owner

I agree!

I was also considering introducing the Enter key instead of Ctrl + O but never did.

However, regarding the Esc key I gave it a try when developing it but for some reason it didn't work and ended up compromising with Ctrl + Q.

Indeed, using a config file would make it much more flexible and it could allow configuring even more things like colors etc. but it will require some more effort.

Feel free to do the PR and choose any direction you like.

@creekorful
Copy link
Collaborator Author

I will try to do it using config file when doing the little app refactoring then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants