Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the toggle buttons of the collapsible drawer #316

Closed
6 of 7 tasks
kvoon3 opened this issue May 11, 2024 · 0 comments · Fixed by #317
Closed
6 of 7 tasks

Hide the toggle buttons of the collapsible drawer #316

kvoon3 opened this issue May 11, 2024 · 0 comments · Fixed by #317

Comments

@kvoon3
Copy link
Contributor

kvoon3 commented May 11, 2024

Describe the bug

The toggle buttons of the collapsible drawer should be hidden on small screens and when viewing icon details.

  1. When on a small screen, the drawer is hidden, but the toggle buttons still remain.

chrome_hZ90kKbTKE

  1. When viewing icon details, the icon's z-index is too high

chrome_iYobfuLOwG

Reproduction

Icons page under the /collection route at https://icones.js.org/collection.

System Info

System:
  OS: Windows 10 10.0.19044
  CPU: (12) x64 AMD Ryzen 5 5600G with Radeon Graphics          
  Memory: 526.64 MB / 13.90 GB
Binaries:
  Node: 20.12.2 - C:\Program Files\nodejs\node.EXE
  npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
  pnpm: 8.10.2 - C:\workspaceS\icones\node_modules\.bin\pnpm.CMD
Browsers:
  Edge: Chromium (123.0.2420.97)
  Internet Explorer: 11.0.19041.3636

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant