Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using '--help', also need to choose agent #110

Closed
smallnine9 opened this issue Oct 19, 2022 · 3 comments
Closed

Using '--help', also need to choose agent #110

smallnine9 opened this issue Oct 19, 2022 · 3 comments

Comments

@smallnine9
Copy link
Contributor

Additional context

if we use ni -h or ni --help in a folder where no lockfile exists, the ni also always let user choose an agent. may it's a little confused? because '--help' show the ni's help docs, not related to agent.
@smallnine9
Copy link
Contributor Author

https://github.com/antfu/ni/blob/main/src/runner.ts#L48
because in code we first get agent then run command, but maybe '--help' should not perform in this way?

@antfu
Copy link
Member

antfu commented Oct 24, 2022

PR welcome :)

@smallnine9
Copy link
Contributor Author

alright, this is my PR #111
hope I didn't make a mistake :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antfu @smallnine9