Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ordering / sorting after tazing with hypen and underscore #58

Open
5 tasks done
NamesMT opened this issue Feb 17, 2023 · 0 comments
Open
5 tasks done

Wrong ordering / sorting after tazing with hypen and underscore #58

NamesMT opened this issue Feb 17, 2023 · 0 comments

Comments

@NamesMT
Copy link

NamesMT commented Feb 17, 2023

Describe the bug

According with npm/pnpm's default sorting and jsonc/sort-keys, hypen should come before underscore, however, after running taze on the project, the underscore comes before hyphen and causes lint error:

Example packages for reproduction:
fast-equals, fast-xml-parser, fast_array_intersect
Open the reproduction link and run pnpx taze -w

Though, not sure if it's just ignoring hyphen/underscore and just compares the letters or is sorting the underscore first

Reproduction

https://stackblitz.com/edit/node-dqvwar?file=package.json&view=editor

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (16) x64 AMD Ryzen 7 5700U with Radeon Graphics
    Memory: 2.43 GB / 13.85 GB
  Binaries:
    Node: 18.14.0 - D:\Softwares\nodejs\node.EXE
    Yarn: 1.22.19 - D:\Softwares\nodejs\_npm\yarn.CMD
    npm: 9.3.1 - D:\Softwares\nodejs\npm.CMD

Browsers:
Chrome: 102
Firefox: latest

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant