Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/mv3 contentScript HMR is not work #114

Open
5 tasks done
xlzy520 opened this issue Jan 11, 2023 · 8 comments
Open
5 tasks done

refactor/mv3 contentScript HMR is not work #114

xlzy520 opened this issue Jan 11, 2023 · 8 comments

Comments

@xlzy520
Copy link

xlzy520 commented Jan 11, 2023

Describe the bug

code

image

page

image

if refresh the ext
image

page is ok.
image

Reproduction

vitesse-webext/src/contentScripts/index.ts

System Info

System:
    OS: macOS 11.7.1
    CPU: (8) arm64 Apple M1
    Memory: 96.77 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 8.3.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Edge: 103.0.1264.71
    Firefox: 106.0
    Safari: 14.1.2

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@hakadao
Copy link

hakadao commented Mar 28, 2023

SAME, and my solution was to install the Extensions Reloader. After making changes to the extension files, I would on click the Extensions Reloader button and refresh the page to ensure the changes would be applied.

@zf1998
Copy link

zf1998 commented May 21, 2023

@xlzy520 Has the problem been resolved now? I also encountered the same problem.

@tmkx
Copy link
Collaborator

tmkx commented May 22, 2023

refactor/mv3 is deprecated, please use main branch

@louisremi
Copy link

@tmkx as far as I can tell, HMR ins't working for content script on the main branch :-/

@tmkx
Copy link
Collaborator

tmkx commented May 23, 2023

I think it's hard to make HMR working for contentScript? for example, the script is injected to a webpage(.e.g https://example.com),when we try to connect with vite server(protocol http), it should meet a "mixed content" error

@tshemeng
Copy link
Collaborator

tshemeng commented Aug 4, 2023

@tmkx But plasmo did it.

@yunsii
Copy link

yunsii commented Sep 4, 2023

@tmkx as far as I can tell, HMR ins't working for content script on the main branch :-/

It is still not work for now.

@yunsii
Copy link

yunsii commented Sep 6, 2023

@tmkx But plasmo did it.

After I tested, plasmo seems not supported content scripts TRUE HMR, related code: consolidateUpdate(), it reload page roughly, but chrome-extension-tools supported.

ref: PlasmoHQ/plasmo#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants