Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow creating empty commits #23

Merged

Conversation

auvred
Copy link

@auvred auvred commented Dec 15, 2023

Description

After selecting as-is

> npx -y bumpp

? Current version 0.0.1 ›
            major 1.0.0
            minor 0.1.0
            patch 0.0.2
             next 0.0.2
        pre-patch 0.0.2-beta.0
        pre-minor 0.1.0-beta.0
        pre-major 1.0.0-beta.0
❯           as-is 0.0.1
           custom ...

It throws the following

> npx -y bumpp

✔ Current version 0.0.1 ›         as-is 0.0.1

   files package.json
  commit chore: release v0.0.1
     tag v0.0.1
    push yes

    from 0.0.1
      to 0.0.1

✔ Bump? … yes
ℹ package.json did not need to be updated
git commit --message "chore: release v0.0.1" exited with a status of 1.
 ELIFECYCLE  Command failed with exit code 1.

Because there is no changes (version in package.json hasn't changed). I guess bumpp should allow creating empty commits (the as-is option means just that, right?)

Linked Issues

Additional context

@antfu antfu merged commit 1e07b7c into antfu-collective:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants