Skip to content

Commit

Permalink
fix(cli): improve eslint version
Browse files Browse the repository at this point in the history
  • Loading branch information
antfu committed Nov 21, 2023
1 parent 478b3ab commit 8055331
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -36,7 +36,7 @@
"prepare": "simple-git-hooks"
},
"peerDependencies": {
"eslint": ">=8.0.0"
"eslint": ">=8.40.0"
},
"dependencies": {
"@antfu/eslint-define-config": "^1.23.0-2",
Expand Down
3 changes: 2 additions & 1 deletion src/cli/constants.ts
@@ -1,11 +1,12 @@
import c from 'picocolors'
import { version } from '../../package.json'
import { devDependencies, version } from '../../package.json'

export const ARROW = c.cyan('→')
export const CHECK = c.green('✔')
export const CROSS = c.red('✘')
export const WARN = c.yellow('ℹ')

export const eslintVersion = devDependencies.eslint
export { version }

export const vscodeSettingsString = `
Expand Down
4 changes: 2 additions & 2 deletions src/cli/run.ts
Expand Up @@ -8,7 +8,7 @@ import c from 'picocolors'

// @ts-expect-error missing types
import parse from 'parse-gitignore'
import { ARROW, CHECK, WARN, version, vscodeSettingsString } from './constants'
import { ARROW, CHECK, WARN, eslintVersion, version, vscodeSettingsString } from './constants'
import { isGitClean } from './utils'

export interface RuleOptions {
Expand Down Expand Up @@ -45,7 +45,7 @@ export async function run(options: RuleOptions = {}) {
pkg.devDependencies['@antfu/eslint-config'] = `^${version}`

if (!pkg.devDependencies.eslint)
pkg.devDependencies.eslint = '^8'
pkg.devDependencies.eslint = eslintVersion

await fsp.writeFile(pathPackageJSON, JSON.stringify(pkg, null, 2))
console.log(c.green(`${CHECK} changes wrote to package.json`))
Expand Down

0 comments on commit 8055331

Please sign in to comment.