feat: ban new Array

[zanminkian]

Description

The parameter of Array constructor is the design mistake which is ambiguous and hard to use. Banning this will be convenient for code review. Because some time I will forget:

new Array(5) // An array with 5 items? Or one item in an array?

Linked Issues

Additional context

[zanminkian]

Check the doc: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-new-array.md

[zanminkian]

We have enable no-new-wrappers to ban new Number and new String etc. So it reasonable to ban new Array too.

[antfu]

I never used new Array and did even know it worked - I am ok having it, but I am also ok with not having it because it makes no difference at all. This leads me thinking what's the performance cost of checking a syntax that no one uses?

[zanminkian]

I don't know how much time it would take to add one rules. But eslint is quite slow. For performance, eslint is not a good solution, but Rome is.

Although you don't use new Array, other developer may use it and submit a PR to your project. 😆

Maybe we should re-think what's the case this preset use for. For linting on pre-commit git hooks only? What about linting on CI/CD? I hope this preset is all-inclusive to kill the shit code.

[zanminkian]

I believe no body use with statement in js, but this preset ban it. From my humble opinion, we should accept all the reasonable rule and ignore the performance reason.