Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ban declarations in ts file #264

Merged
merged 9 commits into from Oct 5, 2023
Merged

feat: ban declarations in ts file #264

merged 9 commits into from Oct 5, 2023

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented Oct 4, 2023

Description

Linked Issues

close #216

Additional context

@so1ve
Copy link
Contributor Author

so1ve commented Oct 4, 2023

Shall we deprecated those rules in eslint-plugin-antfu?

@so1ve so1ve changed the title feat: ban declarations in ts file feat: ban declarations in d.ts file Oct 4, 2023
@@ -116,6 +116,8 @@ export function javascript(options: OptionsIsInEditor & OptionsOverrides = {}):
'DebuggerStatement',
'LabeledStatement',
'WithStatement',
'TSEnumDeclaration[const=true]',
Copy link
Contributor Author

@so1ve so1ve Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By banning TS syntax in JS config we don't have to maintain two separated restricted syntax lists

@so1ve so1ve changed the title feat: ban declarations in d.ts file feat: ban declarations in ts file Oct 4, 2023
@antfu
Copy link
Owner

antfu commented Oct 5, 2023

Yeah let's deprecate them.

@antfu antfu merged commit a76fde9 into antfu:main Oct 5, 2023
@so1ve so1ve deleted the patch-1 branch October 5, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban declaration in ts file
2 participants