feat: update jsx default config #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`style/jsx-child-element-spacing`, `style/jsx-one-expression-per-line`, These two rules seem to conflict, never verified correctly
|
|
same here. currently I disable both of them |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the JSX configuration to make it resemble the formatting of Prettier(Not 100% consistent).
Linked Issues
#185
Additional context
In many projects, JSX files are typically automatically formatted using Prettier, such as in Next.js. Therefore, there's often no need to configure JSX rules in eslint-plugin-react to achieve a consistent JSX format.
Now, if we want to use ESLint for JSX formatting instead of Prettier, it would be beneficial to ensure that the JSX configuration closely matches the formatting produced by Prettier for consistency.
I use jsx a lot, so I configured eslint rules according to the prettier style. Due to the limitations of eslint jsx rules, it is not yet completely consistent with Prettier and can only be as similar as possible. Perhaps it can be optimized in the future.