Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #289 #302

Merged
merged 1 commit into from Oct 29, 2023
Merged

fix: revert #289 #302

merged 1 commit into from Oct 29, 2023

Conversation

qin-guan
Copy link
Contributor

This reverts commit ba704e7.

Description

Reverting change as it breaks camel case components which are imported within SFC itself, even though it is valid SFC syntax. For example, using framework7-vue where component names are prefixed with f7:

<script setup lang="ts">
	import { f7Button } from 'framework7-vue'
</script>

<template>
	<f7Button>Hello</f7Button>
</template>

It will get fixed to

<script setup lang="ts">
</script>

<template>
	<F7Button>Hello</F7Button>
</template>

Which is invalid.

Linked Issues

NA

Additional context

Related comment.

@antfu antfu changed the title Revert "fix: enforce name casing for unregistered components (#289)" fix: revert #289 Oct 29, 2023
@antfu antfu merged commit 52b4fe5 into antfu:main Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants