feat: support more fields of packageJson as ascending order #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Emmm, I'm not sure why it failed under windows and the other platforms passed, it doesn't look like a rule issue 🧐 |
antfu
reviewed
Dec 11, 2023
mutoe
force-pushed
the
package-json-misc-order
branch
from
1f19e8b
to
1c63cd5
Compare
|
Got it, already exclude script and lint properties of ascending order |
antfu
reviewed
Dec 19, 2023
| 'pre-push', | ||
| 'pre-auto-gc', | ||
| ], | ||
| pathPattern: '^(?:gitHooks|husky|simple-git-hooks)$', |
There was a problem hiding this comment.
I am not sure whether to have this tool-specific configuration either... Also, how is this order decided?
There was a problem hiding this comment.
It comes from official git hooks page https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the sort fields I usually use, and you can decide what rules are needed of the project. You can modify them directly or bring them up. Happy to contribute :)
scriptsgitHooks,husky,simple-git-hooks)eslintConfigstylelintLinked Issues
-
Additional context
-