Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.9.1 have a peer-dependency of eslint-plugin-svelte@^2.36.0-0, which is not released yet #437

Closed
5 tasks done
CNSeniorious000 opened this issue Mar 27, 2024 · 2 comments

Comments

@CNSeniorious000
Copy link

Describe the bug

v2.9.0 works well, but when I updated to v2.9.1+ the minimal version of eslint-plugin-svelte changed to ^2.36.0-0. But for now the latest version is ^2.35.1

This make sveltekit application on vercel and netlify deployments fail

Try the following reproduction by install dependencies and then pnpm eslint ., it will automatically install eslint-plugin-svelte but raising a peer-dependency warning

Reproduction

https://stackblitz.com/edit/vitejs-vite-g1tdbd?file=package.json

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 7840HS w/ Radeon 780M Graphics
    Memory: 1.96 GB / 15.18 GB
  Binaries:
    Node: 20.9.0 - D:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - ~\AppData\Local\pnpm\yarn.CMD
    npm: 10.1.0 - D:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.5 - ~\AppData\Local\pnpm\pnpm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.53)
    Internet Explorer: 11.0.22621.1

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@antfu
Copy link
Owner

antfu commented Mar 28, 2024

We could revert it to the latest stable version, PR welcome :)

@CNSeniorious000
Copy link
Author

OK, then should the version field be 2.9.2 or just 2.11.4?

@antfu antfu closed this as completed in 0b364ee Mar 28, 2024
pnodet added a commit to nivalis-studio/eslint-config that referenced this issue Apr 2, 2024
* antfu/main:
  chore: release v2.11.6
  feat: generate types for core rules as well, resolve antfu#439
  docs: move to `@eslint/config-inspector`
  chore: release v2.11.5
  fix: consistent on config names
  chore: bump `@antfu/install-pkg` to ^0.3.2 (antfu#438)
  chore: release v2.11.4
  fix: lower peer-deps requirement to `eslint-plugin-svelte`, fix antfu#437
  fix(cli): make frameworks not required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants