Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with @stylistic/indent and @stylistic/jsx-indent #440

Closed
5 tasks done
yunsii opened this issue Mar 31, 2024 · 3 comments
Closed
5 tasks done

Conflict with @stylistic/indent and @stylistic/jsx-indent #440

yunsii opened this issue Mar 31, 2024 · 3 comments

Comments

@yunsii
Copy link
Contributor

yunsii commented Mar 31, 2024

Describe the bug

An error will be reported anyway
image

Reproduction

https://github.com/yunsii/stylistic-repro/blob/master/src/index.tsx

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (12) x64 Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz
    Memory: 11.29 GB / 15.52 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v18.19.0/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v18.19.0/bin/npm
    pnpm: 8.11.0 - ~/.nvm/versions/node/v18.19.0/bin/pnpm

Used Package Manager

npm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@antfu
Copy link
Owner

antfu commented Mar 31, 2024

I don't use JSX myself, thus I won't have enough incentive to work on it any sooner. Pr welcome if anyone want to investigate and find a solution

@yunsii
Copy link
Contributor Author

yunsii commented Apr 4, 2024

After investigation, I think it is a bug for @stylistic/jsx-indent with checkAttributes: true. For example:

image

After disable checkAttributes:

image

@yunsii
Copy link
Contributor Author

yunsii commented Apr 4, 2024

Upstream issue: eslint-stylistic/eslint-stylistic#312

@antfu antfu closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants