fix: if there are spaces in args, then wrap them with quotes #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Jun 16, 2023
antfu
reviewed
Jun 16, 2023
src/parse.ts
Outdated
Comment on lines
29
to
32
| const hasIfPresent = arg.startsWith('--if-present ') | ||
| const prefix = hasIfPresent ? '--if-present ' : '' | ||
| if (hasIfPresent) | ||
| arg = arg.slice('--if-present '.length) |
There was a problem hiding this comment.
https://github.com/antfu/ni/blob/d7951e7b5a5822a496c1f8c75c152c379bda4ab7/src/parse.ts#L59
Because --if-present has been inserted into the first parameter.
I tried to replace
args[0] = `--if-present ${args[0]}`
to args.unshift('--if-present'), but this could lead to other issues, perhaps you could make some overall adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #157