feat: support detect the range version of packageManager #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wxh16144
reviewed
Oct 18, 2023
| @@ -32,7 +32,7 @@ export async function detect({ autoInstall, programmatic, cwd }: DetectOptions = | |||
| try { | |||
| const pkg = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8')) | |||
| if (typeof pkg.packageManager === 'string') { | |||
| const [name, ver] = pkg.packageManager.split('@') | |||
| const [name, ver] = pkg.packageManager.replace(/^\^/, '').split('@') | |||
There was a problem hiding this comment.
这里是不是可以用正则表达式来判断？
const [, name, ver] = packageManager.match(new RegExp(`^(${Object.values(LOCKS).join('|')})@(\\d+\\.\\d+\\.\\d)+(-.+)?`)) || []There was a problem hiding this comment.
Using regexp gets complicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue from ant-design/ant-design#45327
Corepack has supported a range version for a long time. You can see nodejs/corepack#136
Linked Issues
Additional context