Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bun): lowercase -D paremeter if the agent is bun #90

Merged
merged 21 commits into from Jul 14, 2022

Conversation

eggsy
Copy link
Contributor

@eggsy eggsy commented Jul 14, 2022

because bun doesn't accept -D but does accept -d, stupid.

  • also fixed readme issue and added a basic .prettierrc file
  • added missing bun examples in readme.md, and put bun notices

@eggsy eggsy mentioned this pull request Jul 14, 2022
@antfu
Copy link
Member

antfu commented Jul 14, 2022

  1. I don't use Prettier, we should not have a pretterrc
  2. For tests of bun, I think it's better to keep the tests but expect them to fail, so in the future, when bun supports them we could then do the update.

src/parse.ts Outdated Show resolved Hide resolved
@eggsy
Copy link
Contributor Author

eggsy commented Jul 14, 2022

didn't quite understand what you meant by "expect to fail" but added the file back, it's still throwing "command x is not supported by the agent" but it builds fine

@eggsy
Copy link
Contributor Author

eggsy commented Jul 14, 2022

oh, got it now 🤣 can tell i never do testing

@antfu antfu merged commit 299d8e7 into antfu-collective:main Jul 14, 2022
kodiakhq bot pushed a commit to singlestone/sugar that referenced this pull request Jul 25, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@antfu/ni](https://togithub.com/antfu/ni) | [`0.16.3` -> `0.17.2`](https://renovatebot.com/diffs/npm/@antfu%2fni/0.16.3/0.17.2) | [![age](https://badges.renovateapi.com/packages/npm/@antfu%2fni/0.17.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@antfu%2fni/0.17.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@antfu%2fni/0.17.2/compatibility-slim/0.16.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@antfu%2fni/0.17.2/confidence-slim/0.16.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>antfu/ni</summary>

### [`v0.17.2`](https://togithub.com/antfu/ni/releases/tag/v0.17.2)

[Compare Source](https://togithub.com/antfu/ni/compare/v0.17.1...v0.17.2)

#####    🐞 Bug Fixes

-   **bun**: Lowercase -D paremeter if the agent is bun  -  by [@&#8203;eggsy](https://togithub.com/eggsy) and [@&#8203;antfu](https://togithub.com/antfu) in [antfu-collective/ni#90

#####     [View changes on GitHub](https://togithub.com/antfu/ni/compare/v0.17.1...v0.17.2)

### [`v0.17.1`](https://togithub.com/antfu/ni/releases/tag/v0.17.1)

[Compare Source](https://togithub.com/antfu/ni/compare/v0.17.0...v0.17.1)

#####    🐞 Bug Fixes

-   `bun.lockb` takes higher priority  -  by [@&#8203;antfu](https://togithub.com/antfu) [<samp>(a4e1c)</samp>](https://togithub.com/antfu/ni/commit/a4e1c49)

#####     [View changes on GitHub](https://togithub.com/antfu/ni/compare/v0.17.0...v0.17.1)

### [`v0.17.0`](https://togithub.com/antfu/ni/releases/tag/v0.17.0)

[Compare Source](https://togithub.com/antfu/ni/compare/v0.16.3...v0.17.0)

#####    🚀 Features

-   Support `bun`  -  by [@&#8203;eggsy](https://togithub.com/eggsy) and [@&#8203;antfu](https://togithub.com/antfu) in [antfu-collective/ni#89

#####     [View changes on GitHub](https://togithub.com/antfu/ni/compare/v0.16.3...v0.17.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/singlestone/sugar).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjIuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEyMi4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants