Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: singlelineCommentsRE incorrect matching #3

Merged
merged 3 commits into from Sep 18, 2022
Merged

Conversation

YIngChenIt
Copy link
Contributor

@YIngChenIt YIngChenIt commented Sep 17, 2022

Description

const url= `http://xxxxx`;

stripLiteralRegex(url) // `http:

result of stripLiteralRegex() is unreasonable

result should be http://xxxxx

I'm investigating nuxt3

It was finally found that the reason was detectImports(unimport) deal code error

So locate here

Linked Issues

Additional context

@antfu
Copy link
Owner

antfu commented Sep 18, 2022

Could you add a few tests for it? Thanks

@YIngChenIt
Copy link
Contributor Author

你可以为它添加一些测试吗?谢谢

before today

@antfu antfu merged commit 6d87f32 into antfu:main Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants