fix: equality check eslintrc-auto-import.json #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuveth
changed the title
samuveth
referenced
this pull request
May 11, 2023
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
|
Maybe we could compare with |
antfu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request aims to improve the interoperability between
unplugin-auto-importand code formatting tools such as Prettier and ESLint.Currently, the
eslintrc-auto-import.jsonfile generated byunplugin-auto-importlacks a newline at the end. This absence often leads to conflicts with Prettier and ESLint, as both of these tools conventionally expect a newline at the end of files.To address this, the
writeFilemethod in the plugin has been updated to append a newline to the file content before writing toeslintrc-auto-import.json. This small change should help in maintaining smoother integration with code formatting tools and eliminate the unnecessary conflicts that users are currently experiencing.