feat: support rspack #385
Merged
feat: support rspack #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's also a basic proof of concept of a Vue app bundled by Rspack, using this PR's branch for auto-importing: https://github.com/loilo/rspack-vue-demo |
antfu
reviewed
May 30, 2023
| import type { Options } from './types' | ||
| import unplugin from '.' | ||
|
|
||
| // TODO: some upstream lib failed generate invalid dts, remove the any in the future |
There was a problem hiding this comment.
Can you send a PR to unplugin as well? Thank you
There was a problem hiding this comment.
What's the problem with the type? Isn't it related to unplugin?
There was a problem hiding this comment.
Oh okay, I misunderstood your first question, I'm sorry.
I don't actually know what the problem is. The any typing and the comment are present in all the bundler files (see vite.ts, webpack.ts, rollup.ts, …), but I don't know the reason they've been there in the first place.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
rspackexport to the package, using unplugin's experimental rspack support.Linked Issues
This has not been brought up yet.
Additional context
rspack just recently added support for vue-loader. As far as I have tested it, this works flawlessly. Having Vue support in rspack was a good occasion to look for rspack support in some popular build tools that commonly come with Vue projects.