fix: update qwik support #291
Merged
+26
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerty287
referenced
this pull request
in woodpecker-ci/woodpecker
Sep 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unplugin-icons](https://togithub.com/antfu/unplugin-icons) | [`^0.16.3` -> `^0.17.0`](https://renovatebot.com/diffs/npm/unplugin-icons/0.16.3/0.17.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>antfu/unplugin-icons (unplugin-icons)</summary> ### [`v0.17.0`](https://togithub.com/unplugin/unplugin-icons/releases/tag/v0.17.0) [Compare Source](https://togithub.com/antfu/unplugin-icons/compare/v0.16.6...v0.17.0) ##### 🚨 Breaking Changes - Add support for Svelte 4 - by [@​userquin](https://togithub.com/userquin) in [https://github.com/unplugin/unplugin-icons/issues/297](https://togithub.com/unplugin/unplugin-icons/issues/297) [<samp>(263a9)</samp>](https://togithub.com/unplugin/unplugin-icons/commit/263a9ef) ##### [View changes on GitHub](https://togithub.com/unplugin/unplugin-icons/compare/v0.16.6...v0.17.0) ### [`v0.16.6`](https://togithub.com/unplugin/unplugin-icons/releases/tag/v0.16.6) [Compare Source](https://togithub.com/antfu/unplugin-icons/compare/v0.16.5...v0.16.6) ##### 🐞 Bug Fixes - **compiler-solid**: Props replacement not working with multiline starttags - by [@​NathanHuisman](https://togithub.com/NathanHuisman) in [https://github.com/antfu/unplugin-icons/issues/301](https://togithub.com/antfu/unplugin-icons/issues/301) [<samp>(5668f)</samp>](https://togithub.com/antfu/unplugin-icons/commit/5668fbb) - **types**: Fix type errors - by [@​zyyv](https://togithub.com/zyyv) in [https://github.com/antfu/unplugin-icons/issues/299](https://togithub.com/antfu/unplugin-icons/issues/299) [<samp>(79412)</samp>](https://togithub.com/antfu/unplugin-icons/commit/7941238) ##### [View changes on GitHub](https://togithub.com/antfu/unplugin-icons/compare/v0.16.5...v0.16.6) ### [`v0.16.5`](https://togithub.com/unplugin/unplugin-icons/releases/tag/v0.16.5) [Compare Source](https://togithub.com/antfu/unplugin-icons/compare/v0.16.4...v0.16.5) ##### 🐞 Bug Fixes - Explicit .cjs and .mjs extension - by [@​antfu](https://togithub.com/antfu) [<samp>(45bc0)</samp>](https://togithub.com/antfu/unplugin-icons/commit/45bc00d) ##### [View changes on GitHub](https://togithub.com/antfu/unplugin-icons/compare/v0.16.4...v0.16.5) ### [`v0.16.4`](https://togithub.com/unplugin/unplugin-icons/releases/tag/v0.16.4) [Compare Source](https://togithub.com/antfu/unplugin-icons/compare/v0.16.3...v0.16.4) ##### 🐞 Bug Fixes - Update qwik support - by [@​michaelhthomas](https://togithub.com/michaelhthomas) in [https://github.com/antfu/unplugin-icons/issues/291](https://togithub.com/antfu/unplugin-icons/issues/291) [<samp>(d3a85)</samp>](https://togithub.com/antfu/unplugin-icons/commit/d3a852f) ##### [View changes on GitHub](https://togithub.com/antfu/unplugin-icons/compare/v0.16.3...v0.16.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/woodpecker-ci/woodpecker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Qwik support for
unplugin-iconswas working for a brief period but is no longer working. The example project in this repo does not display an icon, and simply has an emptysvgtag in place of the icon. This PR fixes the Qwik integration and makes importing icons function as expected.Additional context
The root of this issue is that the existing compiler for Qwik was outputting pre-compiled Javascript (not JSX), but was reporting the file type as
tsx. As a result, icons were being double processed, ultimately resulting in a broken component. This PR updates the Qwik compiler to output JSX, and allows the remaining transformations to be handled by the Qwik JSX compiler for better compatibility.