Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compiler.watcher undefined #434

Merged
merged 2 commits into from Jun 26, 2022
Merged

fix: compiler.watcher undefined #434

merged 2 commits into from Jun 26, 2022

Conversation

PatrickChen928
Copy link
Contributor

@PatrickChen928 PatrickChen928 commented Jun 25, 2022 •
edited

some scenes, compile.mode is development, but compiler.watcher is undefined. For example:

  1. webpack.config.js set mode development but watch: false.
  2. plugin is executed earlier than new Watching, that maybe lead file changed but Watching have not been instantiated.
  3. compiler.watching is supported since webpack@5.0.0-rc.1

close #436

@PatrickChen928 PatrickChen928 marked this pull request as ready for review June 26, 2022 11:54
@antfu antfu merged commit 00fcab2 into unplugin:main Jun 26, 2022
@PatrickChen928 PatrickChen928 deleted the fix/webpack-hot branch June 26, 2022 13:42
@PatrickChen928 PatrickChen928 mentioned this pull request Jun 26, 2022
Closed
@seasnakes seasnakes mentioned this pull request Aug 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu antfu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler.watching.invalidate() on npm run serve for Vue 2
2 participants
@PatrickChen928 @antfu