Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove special char in namespace #513

Merged
merged 1 commit into from Sep 26, 2022

Conversation

azaleta
Copy link
Contributor

@azaleta azaleta commented Sep 19, 2022

Description

closes #511

Linked Issues

Additional context

@azaleta azaleta requested a review from antfu as a code owner September 19, 2022 06:24
@antfu antfu merged commit 5aafb35 into unplugin:main Sep 26, 2022
@azaleta azaleta deleted the component-special-char branch September 26, 2022 03:32
@lxchapu
Copy link

lxchapu commented Oct 8, 2022

I think a new issue is created in src/core/utils.ts line 142.

- should be allowed in the regexp, so the following test cases should be passed

const inComponentFilePath = '/src/components/a-b/c.vue'
expect(getNameFromFilePath(inComponentFilePath, options as ResolvedOptions)).toBe('a-b-c')

thanks!
@azaleta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid component names
3 participants