Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrap-vue-3 resolver #520

Merged
merged 2 commits into from Oct 24, 2022
Merged

feat: bootstrap-vue-3 resolver #520

merged 2 commits into from Oct 24, 2022

Conversation

VividLemon
Copy link
Contributor

@VividLemon VividLemon commented Oct 4, 2022

Description

bootstrap-vue-3 resolver

Additional context

I had created an example in the ./examples folder to test my work on. Everything seemed to be working, the components imported, built, and worked in dev, but what wasn't working was the automatic types. The resolver correctly imported the type for GlobalComponents type, but despite this, the template didn't give intellisense on component props. Does someone know why this is? Is it possible that the setup here has anything to do with it?

I will need to go in at a later time, I'm not 100% certain that the directives are working correctly, but it's hard to test.

@VividLemon VividLemon requested a review from antfu as a code owner October 4, 2022 15:02
@antfu antfu marked this pull request as draft October 9, 2022 07:49
@VividLemon
Copy link
Contributor Author

@antfu In the title it says wip, from my testing, it works well enough, I just added that as a note that I may change it in the future. Since BV3 is still alpha and may change.

@VividLemon VividLemon changed the title feat: bootstrap-vue-3 resolver WIP feat: bootstrap-vue-3 resolver Oct 15, 2022
@VividLemon VividLemon marked this pull request as ready for review October 15, 2022 13:25
@antfu antfu merged commit b58ed85 into unplugin:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants