Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vue 2.7 #529

Merged
merged 14 commits into from Oct 24, 2022
Merged

feat: support vue 2.7 #529

merged 14 commits into from Oct 24, 2022

Conversation

azaleta
Copy link
Contributor

@azaleta azaleta commented Oct 21, 2022

Description

Concept is get vue2 minor version from plugin-name.

less than 2.7.0 -> vite-plugin-vue2
2.7.0+ -> @vitejs/plugin-vue2

Linked Issues

closes #463, closes #528

Additional context

@azaleta azaleta requested a review from antfu as a code owner October 21, 2022 10:46
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azaleta
Copy link
Contributor Author

azaleta commented Oct 21, 2022

you mean set version in config manually?

@sxzz
Copy link
Member

sxzz commented Oct 21, 2022

Yes.

src/types.ts Outdated Show resolved Hide resolved
src/core/declaration.ts Outdated Show resolved Hide resolved
@azaleta
Copy link
Contributor Author

azaleta commented Oct 21, 2022

Thank you!

@sxzz
Copy link
Member

sxzz commented Oct 21, 2022

/cc @antfu

src/core/options.ts Outdated Show resolved Hide resolved
@sxzz sxzz requested a review from antfu October 22, 2022 12:09
src/core/options.ts Outdated Show resolved Hide resolved
@antfu antfu changed the title Vue2.7 feat: support vue 2.7 Oct 24, 2022
@antfu antfu merged commit 2a120ee into unplugin:main Oct 24, 2022
@azaleta azaleta deleted the vue2.7 branch October 24, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants