fix(array): toArray
- convert to empty array only for nullish
#20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the
Nullable
type of the argument, it looks like we only want to convertnull
andundefined
into empty array. But in the current logic, falsy values (such as0
,false
,''
, etc.) are also being converted. It is probably better to respect these values.If there is a good reason to bypass the falsy values, please feel free to close this PR.
Linked Issues
NA
Additional context
I think we should take advantage of
it.each
for looping through test casesinput
andexpected (output)
of test cases are grouped in the same format[input, expected]
I have added test cases for
toArray
function as the demo