Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to built-in "Simple browser" #26

Open
3 tasks done
septatrix opened this issue Nov 26, 2022 · 0 comments
Open
3 tasks done

Switch to built-in "Simple browser" #26

septatrix opened this issue Nov 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@septatrix
Copy link

Clear and concise description of the problem

Currently there is a plethora of bugs with the embedded browser. It...

Suggested solution

VSCode has a built-in "Simple browser" extension since a while ago: microsoft/vscode#109276

As it is a proper built-in extension and uses the rendering engine already embedded inside electron it does not suffer from the problems of the current screensharing architecture. This will likely resolve every issue listed above!

Alternative

Fix vscode-browse-lite, though I do not consider this worth the effort given the limitations of it architecture.

Additional context

The only drawback will be that devtools will be a bit less nice. One has to use the electron devtools (Help > Toggle Developer Tools) which are not in a nice tab like the current ones. However, I definitely consider this drawback justified given the amount of advantages this switch would bring.
Furthermore, one can still open it in an external browser if some parts of the devtools are limiting inside VSCode.

Validations

@septatrix septatrix added the enhancement New feature or request label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant