Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded browser doesn't open #8

Open
ashishbinu opened this issue May 21, 2021 · 5 comments
Open

Embedded browser doesn't open #8

ashishbinu opened this issue May 21, 2021 · 5 comments

Comments

@ashishbinu
Copy link

After clicking the vite button at bottom status bar, I clicked on open with embedded browser and it showed error as shown in image below:

@antfu
Copy link
Owner

antfu commented May 21, 2021

Have you installed Chrome?

@ashishbinu
Copy link
Author

@antfu I have chrome installed.
image

@CreatorB
Copy link

CreatorB commented Jun 6, 2021

@antfu I have chrome installed.
image

Hi, @ashishbinu I've got the same issue here, but already solved by manually add a chrome path on the extension setting, see attached screenshot below.

image

@ashishbinu
Copy link
Author

Yeah , It worked but shouldn't it work without giving the path. Whoever is gonna install it in linux might not have it working when they run it.

@antfu
Copy link
Owner

antfu commented Jun 10, 2021

If you find a way to cover your cases to do the auto-detection, I am more than happy to receive contributions to that.

https://github.com/antfu/vscode-browse-lite/blob/2995249e7332675ff3e719a8b0a9567cfcb7dd39/src/BrowserClient.ts#L69-L82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants