Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong role(s) used on permissions/cleanup tasks #34

Open
WengerK opened this issue Nov 16, 2020 · 0 comments
Open

Fix wrong role(s) used on permissions/cleanup tasks #34

WengerK opened this issue Nov 16, 2020 · 0 comments

Comments

@WengerK
Copy link
Member

WengerK commented Nov 16, 2020

馃挰 Describe the bug

Most of the task must run on the app permission. This is important to use the proper permission especially for people using a multiserver loadbalancing. Where some command should be run only on 1 server to avoid File Stale issues (cleanup drush cr on shared files for example on 2 servers at the same time).

To avoid many of those probleme, we should fix the permissions/cleanup tasks where we use app instead of web - especially on the release cleanup fodler. As those directories are created on all mirror-server and therefore should be fixed on all server - not only `app.

    desc 'Set cleanup permissions to allow deletion of releases'
    task :cleanup do
-      on roles(:app) do
+      on roles(:web) do
        releases = capture(:ls, '-x', releases_path).split
        valid, invalid = releases.partition { |e| /^\d{14}$/ =~ e }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant