Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks to be broken on latest Node.js (10.1.0) #7

Closed
antongolub opened this issue May 17, 2018 · 3 comments
Closed

Looks to be broken on latest Node.js (10.1.0) #7

antongolub opened this issue May 17, 2018 · 3 comments

Comments

@antongolub
Copy link
Owner

antongolub commented May 17, 2018

npm test
response › proto › on
TypeError: Cannot read property 'content-type' of undefined

Should be related to the latest http module changes: nodejs/node#20250

@apapirovski
Copy link

apapirovski commented May 17, 2018

@antongolub Do you happen to know what's breaking it? We certainly didn't intend to break any third-party modules with that change. If you can point me to the relevant code in this module, I would be happy to look at what we can do.

Edit: Oh, I'm guessing this might be due to the some of the stricter checks. I see that you're just using prototype methods but not necessarily applying them to data matching our classes. (Our values are always null when empty but in your case it looks it's undefined.)

@antongolub
Copy link
Owner Author

antongolub commented May 17, 2018

I've used mixins and some part of OutgoingMessage constructor logic was skipped.
In my case this[outHeadersKey] equals undefined, but your commit brought more strict assertion === null. Nevermind, it's easy to fix.

And thank you for attention.

antongolub pushed a commit that referenced this issue May 17, 2018
<a name="1.4.1"></a>
## [1.4.1](v1.4.0...v1.4.1) (2018-05-17)

### Bug Fixes

* **response:** initialize inner _headers map for node v10.1.0 compatibility ([cf19b6d](cf19b6d)), closes [#7](#7)
@antongolub
Copy link
Owner Author

🎉 This issue has been resolved in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants