Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@deprecated fields in input type objects are not documented #827

Closed
sahingoko opened this issue Jun 9, 2023 · 4 comments · Fixed by #828
Closed

@deprecated fields in input type objects are not documented #827

sahingoko opened this issue Jun 9, 2023 · 4 comments · Fixed by #828
Assignees
Labels
enhancement New feature or request needs-triaging

Comments

@sahingoko
Copy link

Hi,
We are using @deprecated directive to mark field deprecation in our schema. And those are correctly documented with spectaql for object types other than input. With input objects, fields that are marked with the @deprecated directive is not documented at all, although schema is working fine and accepting those input fields. Is that intentional?

@newhouse newhouse self-assigned this Jun 9, 2023
@newhouse
Copy link
Collaborator

@sahingoko

I just looked into this and found a few things:

So, I'll be adding this in now as an option for you and others. Will try to have this out in the next hour or two.

@newhouse
Copy link
Collaborator

@sahingoko this is now supported in 2.1.0 that I just published.

Because it's sort of a "breaking" change, it's not enabled by default. You'll need to set the introspection.inputValueDeprecation option to true in your config file, but then it should work.

@newhouse newhouse added the enhancement New feature or request label Jun 12, 2023
@newhouse
Copy link
Collaborator

@sahingoko does it work as expected for you?

@sahingoko
Copy link
Author

@newhouse Yes, I just tested it in test environment and looks like it is working fine. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants