fix(core): inconsistent kebab casing comparison (#937)

* fix(core): inconsistent kebab casing comparison

Fixing an issue where operationNames were being filtered out
and not provided to builder.footer.

generateTargetTags returns kebab-cased tags which are then
compared to operation tags which have not been run through
the kebab routine.

map all operation tags with kebab prior to checking that
the tags include a tag.

* fix(core): inconsistent kebab casing comparison

Fixing an issue where operationNames were being filtered out
and not provided to builder.footer.

generateTargetTags returns kebab-cased tags which are then
compared to operation tags which have not been run through
the kebab routine.

map all operation tags with kebab prior to checking that
the tags include a tag.

Added some additional unit tests to ensure that the kebab
routine is Idempotent.

* Update case.test.ts

---------

Co-authored-by: Ian Ferguson <ian.ferguson@uhs.nhs.uk>
Co-authored-by: Melloware <mellowaredev@gmail.com>

Author: 3 people

packages/core/src/utils/case.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest';
 import { pascal } from './case';
+import { kebab } from './case';
 
 describe('pascal case testing', () => {
   it('should convert to pascal case', () => {
@@ -26,3 +27,22 @@ describe('pascal case testing', () => {
     expect(pascal('foo_bar_API')).toBe('FooBarAPI');
   });
 });
+
+describe('kebab-case a few examples', () => {
+    //fix #937, issue #936, results in kebab routine being potentially called
+    //on a string **repeatedly**.
+    //Do some basic kebab case checks
+    //Additionally, test that the kebab routine is Idempotent
+    [
+        ['Pet', 'pet'],
+        ['pet', 'pet'],
+        ['PetTag', 'pet-tag'],
+        ['pet-tag', 'pet-tag'],
+        ['PetTagWithFourWords', 'pet-tag-with-four-words'],
+        ['pet-tag-with-four-words', 'pet-tag-with-four-words'],
+    ].forEach(([input, expected]) => {
+        it(`should process ${input} to ${expected}`, () => {
+            expect(kebab(input)).toBe(expected);
+        });
+    });
+});

packages/core/src/writers/target-tags.ts

@@ -104,7 +104,7 @@ export const generateTargetForTags = (
             isAngularClient ? mutator.hasThirdArg : mutator.hasSecondArg,
           );
           const operationNames = Object.values(builder.operations)
-            .filter(({ tags }) => tags.includes(tag))
+            .filter(({ tags }) => tags.map(kebab).includes(kebab(tag)))
             .map(({ operationName }) => operationName);
 
           const typescriptVersion =